Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fuzz test CKBProtocolHandler and ServiceProtocol #4488

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

joii2020
Copy link
Contributor

@joii2020 joii2020 commented Jun 20, 2024

Add fuzz test:

  • CKBProtocolHandler
  • ServiceProtocol. Some tentact test code was committed to here.

@joii2020 joii2020 requested a review from a team as a code owner June 20, 2024 14:41
@joii2020 joii2020 requested review from doitian and removed request for a team June 20, 2024 14:41
}

let db = {
let db_dir = PathBuf::from("/tmp/tmp.db");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using tempfile::temp_dir().

sync/Cargo.toml Outdated
@@ -24,7 +24,7 @@ ckb-chain-spec = { path = "../spec", version = "= 0.117.0-pre" }
ckb-channel = { path = "../util/channel", version = "= 0.117.0-pre" }
ckb-traits = { path = "../traits", version = "= 0.117.0-pre" }
ckb-error = { path = "../error", version = "= 0.117.0-pre" }
ckb-tx-pool = { path = "../tx-pool", version = "= 0.117.0-pre" }
ckb-tx-pool = { path = "../tx-pool", version = "= 0.117.0-pre", features = ["internal"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should feature = ["internal"] be added under [dev-dependencies]?

Copy link

github-actions bot commented Dec 5, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale To be closed due to a lack of activity label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale To be closed due to a lack of activity
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants