Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl filter with transport #4800

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: impl filter with transport #4800

merged 1 commit into from
Feb 12, 2025

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Feb 5, 2025 •
edited
Loading

What problem does this PR solve?

outbound service impl filter with transport：
TCP -> All
WS -> IP and DNS
WSS -> Only DNS

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner February 5, 2025 04:03
@driftluo driftluo requested review from zhangsoledad and removed request for a team February 5, 2025 04:03
@driftluo driftluo force-pushed the filter-with-transport branch from 8248347 to 73881f0 Compare February 5, 2025 04:08
@driftluo driftluo requested a review from quake February 5, 2025 05:45
quake
quake reviewed Feb 12, 2025
View reviewed changes
network/src/services/outbound_peer.rs Outdated Show resolved Hide resolved
network/src/services/outbound_peer.rs Outdated Show resolved Hide resolved
@driftluo driftluo force-pushed the filter-with-transport branch from 73881f0 to 6aef85d Compare February 12, 2025 05:58
@driftluo driftluo added this pull request to the merge queue Feb 12, 2025
Merged via the queue into nervosnetwork:develop with commit 9025f94 Feb 12, 2025
33 checks passed
@driftluo driftluo deleted the filter-with-transport branch February 12, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @quake @eval-exec