Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk examples (in rust, go, java, JS) #201

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Update sdk examples (in rust, go, java, JS) #201

merged 16 commits into from
Oct 24, 2023

Conversation

linnnsss
Copy link
Collaborator

@linnnsss linnnsss commented Oct 19, 2023

  • added github links of SDK code examples in rust, go, java, and lumos, on the nervos ckb sdks page
  • added new pages of SDK code examples under "basics-guides", including an additional intro to these three operation categories (transfer, sudt, DAO operations)

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nervos-ckb-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 6:28am

@jordanmack
Copy link
Collaborator

  • added new pages of SDK code examples under "basics-guides", including an additional intro to these three operation categories (transfer, sudt, DAO operations)

What pages have links to these new examples?

@homura
Copy link
Collaborator

homura commented Oct 19, 2023

There seems a lack of sidebar configuration of SDK examples in the sidebar.json like the following

"type": "category",
"label": "Crypto Wallet",
"items": [
"basics/guides/crypto wallets/neuron",
"basics/guides/crypto wallets/imtoken",
"basics/guides/crypto wallets/safepal",
"basics/guides/crypto wallets/portalwallet",
"basics/guides/crypto wallets/bitpie"
]

update sidebar items according to the newly added sdk examples
@jordanmack
Copy link
Collaborator

Overview Page:

  • It appears you may have been trying to add a link in the first section, but it came out as code.
  • I would recommend a small change for readability. Instead of the three sections being labeled 1, 2, 3, then the subsections a, b, c, make the three sections each a header, followed by a brief description, then the subsections are a 1, 2, 3 list.

@linnnsss

@15168316096
Copy link

15168316096 commented Oct 24, 2023

@linnnsss I have questions about ckb-sdk-swift. I see that the sdk repo has been archived. It feels like it has been a long time. I should be familiar with the current ckb There are quite a few versions of adaptation. Check whether it is necessary to write it in the nvervos ckb sdk document. Also, this repo is not under the nervous network. personal

fix the link and improve framework for better readability
@linnnsss
Copy link
Collaborator Author

Overview Page:

  • It appears you may have been trying to add a link in the first section, but it came out as code.
  • I would recommend a small change for readability. Instead of the three sections being labeled 1, 2, 3, then the subsections a, b, c, make the three sections each a header, followed by a brief description, then the subsections are a 1, 2, 3 list.

@linnnsss

thanks for the suggestions, updated.

@jordanmack jordanmack merged commit acdb234 into nervosnetwork:develop Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants