Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tlc operations wait dual ack #416

Merged
merged 59 commits into from
Jan 2, 2025
Merged

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Dec 22, 2024

  • Rewrite tlc operations with statuses
  • Forwarding TLC need to ack from peer
  • Removing TLC need ack from peer

@chenyukang chenyukang marked this pull request as draft December 22, 2024 03:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 89.69466% with 54 lines in your changes missing coverage. Please review.

Project coverage is 49.85%. Comparing base (bb5ff5f) to head (ed388f1).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/fiber/channel.rs 90.11% 50 Missing ⚠️
src/fiber/network.rs 40.00% 3 Missing ⚠️
src/store/store.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #416      +/-   ##
===========================================
+ Coverage    49.58%   49.85%   +0.27%     
===========================================
  Files           47       47              
  Lines        29802    29812      +10     
===========================================
+ Hits         14776    14863      +87     
+ Misses       15026    14949      -77     
Flag Coverage Δ
unittests 49.85% <89.69%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/fiber/channel.rs Outdated Show resolved Hide resolved
src/fiber/channel.rs Outdated Show resolved Hide resolved
src/fiber/channel.rs Outdated Show resolved Hide resolved
@chenyukang chenyukang marked this pull request as ready for review December 27, 2024 05:19
@chenyukang chenyukang force-pushed the tlc-wait-ack branch 2 times, most recently from cff464c to a97f21f Compare December 28, 2024 11:50
src/fiber/channel.rs Outdated Show resolved Hide resolved
@chenyukang chenyukang changed the title Tlc wait ack Tlc operations wait dual ack Dec 31, 2024
@quake quake merged commit a6e8625 into nervosnetwork:develop Jan 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants