-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tlc operations wait dual ack #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chenyukang
commented
Dec 22, 2024
•
edited
Loading
edited
- Rewrite tlc operations with statuses
- Forwarding TLC need to ack from peer
- Removing TLC need ack from peer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #416 +/- ##
===========================================
+ Coverage 49.58% 49.85% +0.27%
===========================================
Files 47 47
Lines 29802 29812 +10
===========================================
+ Hits 14776 14863 +87
+ Misses 15026 14949 -77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chenyukang
force-pushed
the
tlc-wait-ack
branch
from
December 23, 2024 13:06
94e6baa
to
375147c
Compare
chenyukang
force-pushed
the
tlc-wait-ack
branch
from
December 24, 2024 08:30
924e802
to
00e3c17
Compare
chenyukang
force-pushed
the
tlc-wait-ack
branch
from
December 25, 2024 03:24
7f67839
to
5f779c1
Compare
contrun
reviewed
Dec 25, 2024
chenyukang
force-pushed
the
tlc-wait-ack
branch
from
December 25, 2024 08:48
6794a3c
to
c7c79eb
Compare
chenyukang
force-pushed
the
tlc-wait-ack
branch
2 times, most recently
from
December 28, 2024 11:50
cff464c
to
a97f21f
Compare
chenyukang
force-pushed
the
tlc-wait-ack
branch
from
December 28, 2024 11:53
a97f21f
to
8f94b67
Compare
quake
reviewed
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.