-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate WalletConnet #2880
base: develop
Are you sure you want to change the base?
Conversation
packages/neuron-ui/package.json
Outdated
@@ -53,6 +53,7 @@ | |||
"@nervosnetwork/ckb-sdk-core": "0.109.0", | |||
"@nervosnetwork/ckb-sdk-utils": "0.109.0", | |||
"canvg": "2.0.0", | |||
"ckb-walletconnect-wallet-sdk": "0.0.1-alpha.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be more convenient to move the SDK to this repository and use the yarn workspace feature, or import the SDK via git submodule. This would simplify development as it would not require publishing every change made to the SDK.
/package |
Failed to compile at https://github.com/nervosnetwork/neuron/actions/runs/6545346585/job/17773615195#step:15:94 |
2c95557
to
b682672
Compare
/package |
/package |
8ce0a76
to
43a9d27
Compare
43a9d27
to
0138f11
Compare
/package |
CI failed |
Cell management has been merged by #2859 and this PR can be resumed |
/package |
Is this PR ready for review |
There's still the transaction details and evoking the phone camera part yet to be done, expect ready for review next week. |
Screen-2023-10-18-095333.mp4
scan:
Screen-2023-11-01-094739.mp4