fix undefined variable in junit_xml.sh

nest · Jan 22, 2025 · 26456a7 · 26456a7
1 parent 24d4a39
commit 26456a7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/testsuite/junit_xml.sh b/testsuite/junit_xml.sh
@@ -114,7 +114,7 @@ junit_write ()
         bail_out 'junit_write: report file not open, call junit_open first!'
     fi
 
-    if test -z "$1" -o -z "$2"; then
+    if test -z "$1" -o -z "$2"; then  # Note: this aborts due to "undefined variable", not because of `-z`
         bail_out 'junit_write: classname and testname arguments are mandatory!'
     fi
 
@@ -126,8 +126,9 @@ junit_write ()
         fi
 
         if test "$3" = "failure" ; then
-            echo "    <failure message=\"$4\" type=\"\"><![CDATA["
-            echo "${5/]]>/]]>]]\&gt;<\![CDATA[}"
+            msgdata="${5:-}"
+            echo "    <failure message=\"${4:-}\" type=\"\"><![CDATA["
+            echo "${msgdata/]]>/]]>]]\&gt;<\![CDATA[}"
             echo "]]></failure>"
         fi
         echo "  </testcase>"