Fix for Issues 239 & 262

[mtarking]

Related Issue(s)

Fix to resolve #239 and resolve #262

This PR depends on #249 first.

Related Collection Role

• cisco.nac_dc_vxlan.validate
• cisco.nac_dc_vxlan.dtc.create
• cisco.nac_dc_vxlan.dtc.deploy
• cisco.nac_dc_vxlan.dtc.remove
• other

Related Data Model Element

• vxlan.global
• vxlan.topology
• vxlan.underlay
• vxlan.overlay_services
• vxlan.overlay_extensions
• vxlan.policy
• defaults.vxlan
• other

Proposed Changes

Remove unintended IPv6 check wrapper.
Update templating to better support IPv6 underlay scenarios.
Add rules for mutually exclusive IPv6 parameters.

Test Notes

Different permutations of IPv4 and IPv6 fabric creation tested with:

• IPv4 only
• IPv4 only with TRM
• IPv6 only with link local
• IPv6 only without link local
• IPv6 only with TRM

Cisco NDFC Version

12.2.2

Checklist

• Latest commit is rebased from develop with merge conflicts resolved
• New or updates to documentation has been made accordingly
• Assigned the proper reviewers

[devegupt]

I am reviewing this PR and performed a few tests. It looks like this is solving the #239 but also introducing issues related to the multicast setting. If IPv6 underlay is enabled and we send the replication mode and other related key values to the NDFC, we see a module error, below is one of the error example:

TASK [cisco.nac_dc_vxlan.create : Manage fabric copy_netascode4_vrf_lite_ebgp in NDFC] *******************************************************
Monday 27 January 2025  18:33:54 +0530 (0:00:00.107)       0:00:36.334 ******** 
Monday 27 January 2025  18:33:54 +0530 (0:00:00.107)       0:00:36.334 ******** 
fatal: [copy_netascode4_vrf_lite_ebgp]: FAILED! => changed=false 
  msg: 'The following parameter(value) combination(s) are invalid and need to be reviewed: Fabric: copy_netascode4_vrf_lite_ebgp, REPLICATION_MODE(Multicast) requires UNDERLAY_IS_V6 != True. UNDERLAY_IS_V6 valid values: [False, True]. RP_COUNT(2) requires UNDERLAY_IS_V6 != True, UNDERLAY_IS_V6 valid values: [False, True]. RP_MODE(asm) requires UNDERLAY_IS_V6 != True, UNDERLAY_IS_V6 valid values: [False, True]. RP_LB_ID(128) requires UNDERLAY_IS_V6 != True, UNDERLAY_IS_V6 valid values: [False, True]. BGP_AUTH_KEY_TYPE(3) requires BGP_AUTH_ENABLE == True. BGP_AUTH_ENABLE valid values: [False, True]. BGP_AUTH_KEY(kdjdkdk2333jfjfjfjfjjfke) requires BGP_AUTH_ENABLE == True. BGP_AUTH_ENABLE valid values: [False, True]. '
  response:
  - {}
  result:
  - {}

NO MORE HOSTS LEFT ***************************************************************************************************************************

PLAY RECAP ***********************************************************************************************************************************
copy_netascode4_vrf_lite_ebgp : ok=187  changed=26   unreachable=0    failed=1    skipped=381  rescued=0    ignored=0   

[mtarking]

I am reviewing this PR and performed a few tests. It looks like this is solving the #239 but also introducing issues related to the multicast setting. If IPv6 underlay is enabled and we send the replication mode and other related key values to the NDFC, we see a module error, below is one of the error example:

TASK [cisco.nac_dc_vxlan.create : Manage fabric copy_netascode4_vrf_lite_ebgp in NDFC] *******************************************************
Monday 27 January 2025  18:33:54 +0530 (0:00:00.107)       0:00:36.334 ******** 
Monday 27 January 2025  18:33:54 +0530 (0:00:00.107)       0:00:36.334 ******** 
fatal: [copy_netascode4_vrf_lite_ebgp]: FAILED! => changed=false 
  msg: 'The following parameter(value) combination(s) are invalid and need to be reviewed: Fabric: copy_netascode4_vrf_lite_ebgp, REPLICATION_MODE(Multicast) requires UNDERLAY_IS_V6 != True. UNDERLAY_IS_V6 valid values: [False, True]. RP_COUNT(2) requires UNDERLAY_IS_V6 != True, UNDERLAY_IS_V6 valid values: [False, True]. RP_MODE(asm) requires UNDERLAY_IS_V6 != True, UNDERLAY_IS_V6 valid values: [False, True]. RP_LB_ID(128) requires UNDERLAY_IS_V6 != True, UNDERLAY_IS_V6 valid values: [False, True]. BGP_AUTH_KEY_TYPE(3) requires BGP_AUTH_ENABLE == True. BGP_AUTH_ENABLE valid values: [False, True]. BGP_AUTH_KEY(kdjdkdk2333jfjfjfjfjjfke) requires BGP_AUTH_ENABLE == True. BGP_AUTH_ENABLE valid values: [False, True]. '
  response:
  - {}
  result:
  - {}

NO MORE HOSTS LEFT ***************************************************************************************************************************

PLAY RECAP ***********************************************************************************************************************************
copy_netascode4_vrf_lite_ebgp : ok=187  changed=26   unreachable=0    failed=1    skipped=381  rescued=0    ignored=0   

Will discuss in the standup as mcast is supported for IPv6 underlay. Thanks for reviewing!