Dnac #69
Open
Dnac #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danischm
requested changes
Jan 7, 2025
endpoints_ise.yaml
Outdated
There was a problem hiding this comment.
I think this file should be removed as it already exists under the /examples folder.
| ) | ||
|
|
||
| # Pagination for ERS API results | ||
| elif data.get("SearchResult"): |
There was a problem hiding this comment.
Is this required or just carried over from ISE?
There was a problem hiding this comment.
carried over from ise, removed
| final_dict.update(endpoint_dict) | ||
| return final_dict | ||
|
|
||
| def process_ers_api_results(self, data): |
There was a problem hiding this comment.
its not, removed
| id_value = i["id"] | ||
| except KeyError: | ||
| try: | ||
| id_value = i["rule"]["id"] |
There was a problem hiding this comment.
we don't that was carried over from ise, it can be removed, cause cc doesnt have rule in json body in any of the object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added catalystcenter support (first commit) only supports subset of endpoints