Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxying to github for non-existing local assets #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrey-yantsen
Copy link

In the existing implementation, you need to cache all the possible assets locally, or you won't be able to use them. This PR adds a way for end-users to use locally cached assets and, at the same time, enjoy an occasional non-cached asset.

I'm unsure if including this change in the main docker image is worth it: adding a new docker tag for non-security cautious people/environments where this will be enabled might be a better idea. Or maybe setting up an nginx server on a different port just for that. Please advise how you would like to proceed here.

I'm using netboot.xyz in a tiny just-for-fun homelab environment, and I very much enjoy having a few most-used assets in the local cache and still being able to boot any other available thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant