Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static builder: add snappy.pc #262

Merged
merged 2 commits into from
Dec 28, 2023
Merged

static builder: add snappy.pc #262

merged 2 commits into from
Dec 28, 2023

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Dec 28, 2023 •
edited
Loading

Fixes: netdata/netdata#16677

The upstream snappy sources don’t include a pkg-config file.

Test:

  • build netdata/static-builder:v1 using this branch.
  • build/install Netdata static.
  • check Prometheus remote write in the build info - OK.
  • configure Prometheus remote write exporter, and make sure that it exports data - OK.

@tkatsoulas tkatsoulas marked this pull request as ready for review December 28, 2023 17:44
@tkatsoulas tkatsoulas requested a review from Ferroin as a code owner December 28, 2023 17:44
@tkatsoulas tkatsoulas merged commit 5afb25b into netdata:master Dec 28, 2023
93 checks passed
@ilyam8 ilyam8 deleted the fix-static-add-snappy.pc branch December 28, 2023 17:44
@tkatsoulas
Copy link
Contributor

This is a temporarily workaround, we need to properly bundle the requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkatsoulas tkatsoulas tkatsoulas approved these changes

@Ferroin Ferroin Awaiting requested review from Ferroin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Prometheus Remote Write exporting not working on static binary install
2 participants
@ilyam8 @tkatsoulas