Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy env var for Sentry #269

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add a dummy env var for Sentry #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95fe5a5
Add a dummy env var for Sentry
tkatsoulas Jan 31, 2024
57e6202
Ammend entrypoint
tkatsoulas Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package-builders/Dockerfile.amazonlinux2.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN yum update -y && \
yum install -y autoconf \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.amazonlinux2023.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf clean packages && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.centos-stream8.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf install -y --nodocs 'dnf-command(config-manager)' epel-release && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.centos-stream9.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf install -y --nodocs 'dnf-command(config-manager)' epel-release && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.centos7.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN yum install -y epel-release && \
yum update -y && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.debian10.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ENV VERSION=0.1

# This is needed to ensure package installs don't prompt for any user input.
ENV DEBIAN_FRONTEND=noninteractive
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN apt-get update && \
apt-get upgrade -y && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.debian11.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ENV VERSION=0.1

# This is needed to ensure package installs don't prompt for any user input.
ENV DEBIAN_FRONTEND=noninteractive
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN apt-get update && \
apt-get upgrade -y && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.debian12.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ ENV VERSION=0.1

# This is needed to ensure package installs don't prompt for any user input.
ENV DEBIAN_FRONTEND=noninteractive
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN apt-get update && \
apt-get upgrade -y && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.fedora38.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf clean -y packages && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.fedora39.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf clean -y packages && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.opensuse15.4.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=0.1
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN zypper update -y && \
zypper install -y --allow-downgrade \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.opensuse15.5.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=0.1
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN zypper update -y && \
zypper install -y --allow-downgrade \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.opensusetumbleweed.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN zypper update -y && \
zypper install -y --allow-downgrade \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.oraclelinux8.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

COPY package-builders/ol8-epel.repo /etc/yum.repos.d/ol8-epel.repo

Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.oraclelinux9.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

COPY package-builders/ol9-epel.repo /etc/yum.repos.d/ol9-epel.repo

Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.rockylinux8.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf install -y --nodocs 'dnf-command(config-manager)' epel-release && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.rockylinux9.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ LABEL org.opencontainers.image.description="Package builder image for Netdata of
LABEL org.opencontainers.image.vendor="Netdata Inc."

ENV VERSION=$VERSION
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN dnf distro-sync -y --nodocs && \
dnf install -y --nodocs 'dnf-command(config-manager)' epel-release && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.ubuntu20.04.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ENV VERSION=0.1

# This is needed to keep package installs from prompting about configuration.
ENV DEBIAN_FRONTEND=noninteractive
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN apt-get update && \
apt-get upgrade -y && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.ubuntu22.04.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ENV VERSION=0.1

# This is needed to keep package installs from prompting about configuration.
ENV DEBIAN_FRONTEND=noninteractive
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN apt-get update && \
apt-get upgrade -y && \
Expand Down
2 changes: 2 additions & 0 deletions package-builders/Dockerfile.ubuntu23.10.v1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ENV VERSION=0.1

# This is needed to keep package installs from prompting about configuration.
ENV DEBIAN_FRONTEND=noninteractive
# Dummy Sentry DSN
ENV SENTRY_DSN="https://[email protected]/dummy"

RUN apt-get update && \
apt-get upgrade -y && \
Expand Down
4 changes: 4 additions & 0 deletions package-builders/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
PATH="/cmake/bin:${PATH}"
fi

if [ -n "$NETDATA_SENTRY_DSN" ]; then
SENTRY_DSN="$NETDATA_SENTRY_DSN"

Check warning on line 8 in package-builders/entrypoint.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] package-builders/entrypoint.sh#L8 <ShellCheck.SC2034> 

SENTRY_DSN appears unused. Verify use (or export if used externally).
Raw output 
./package-builders/entrypoint.sh:8:3: warning: SENTRY_DSN appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
fi

fail() {
printf "FAIL: %s\n" "$1"
if [ -t 1 ]; then
Expand Down
Loading