CLEANUP toYaml #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenneth Bingham <[email protected]>
qrkourier
force-pushed
the
tweak-build
branch
from
92c1d6c
to
809ce5e
Compare
qrkourier
force-pushed
the
tweak-build
branch
from
bcf62eb
to
68eadee
Compare
|
Ah, nice. I'll try this. I didn't see your suggestion before it merged to upstream with the 'if ne then true; else false' way. |
|
Also, the conditionals we added in .goreleaser.yml are redundant since the magefile.go avoids running the docker step for the same condition. Still, doesn't hurt anything to express it both places. |
|
superseded by #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also seems to work
goreleaser/goreleaser#5068 (comment)