Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Criterion "TagSubtree" matching the "path_string" of tags #160

Open
wants to merge 3 commits into
base: 5.0
Choose a base branch
from

Conversation

pkamps
Copy link
Contributor

@pkamps pkamps commented Nov 13, 2023

Hi,

for a client project we need to be able to filter by a tag subtree. For example, there is a parent tag called "Category" and there are multiple children tags like "USA", "World" etc.
The content objects only have the tags "USA" or "World" assigned (not the "Category" tag).
We want to be able to find/filter all content that has any children tags of the "Category" tag.

Therefore I developed a new custom Criterion matching values against the DB field "eztags.path_string". Is that something you consider to add to the official repo?

@emodric
Copy link
Member

emodric commented Nov 23, 2023

@pkamps This needs running cs fixer to fix some coding standards issues as well as a phpstan error.

I suppose you did not need Solr visitor, hence no implementation?

@pkamps
Copy link
Contributor Author

pkamps commented Nov 26, 2023

I fixed 1 PHPStan error I introduced. There are 3 remaining but not related to this pull request.
I believe I fixed the CS issues but the checker still fails - maybe it's not configured correctly?

So far, I don't need the Solr visitor - should I implement it to make this pull request more complete?

@emodric
Copy link
Member

emodric commented Nov 28, 2023

I fixed 1 PHPStan error I introduced. There are 3 remaining but not related to this pull request.
I believe I fixed the CS issues but the checker still fails - maybe it's not configured correctly?

Thanks for the fixes! I have no idea about CS Fixer, it worked on last push to master and I will try to fix lingering PHPStan issues once I merge this.

So far, I don't need the Solr visitor - should I implement it to make this pull request more complete?

If it's not too much trouble :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants