feat: cleanup any existing blobs from previous builds as a pre-build command #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
5 tasks
kitop
force-pushed
the
kitop/blob-cleanup
branch
from
924212d to
29b979f
Compare
kitop
force-pushed
the
kitop/blob-cleanup
branch
from
29b979f to
c6fb307
Compare
kitop
changed the title
kitop
changed the title
kitop
commented
Nov 28, 2023
Comment on lines
+5
to
+8
| await Promise.all([ | ||
| writeFile('dist/.netlify/blobs/deploy/with-metadata.txt', 'another value'), | ||
| writeFile('dist/.netlify/blobs/deploy/$with-metadata.txt.json', 'this is not json'), | ||
| ]) |
There was a problem hiding this comment.
I've changed it to write files this way instead of using cp since cp is not available in Node 14 and was failing CI tests
kitop
changed the title
JGAntunes
approved these changes
Nov 28, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup any existing blobs from previous builds as a pre-build command.
Follow up to #5404.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)