fix: when fetching env from envelope, pass context #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
JGAntunes
previously approved these changes
Dec 6, 2023
| if (accountId === undefined) { | ||
| return {} | ||
| } | ||
| try { | ||
| const environmentVariables = await api.getEnvVars({ accountId, siteId }) | ||
| const environmentVariables = await (api as any).getEnvVars({ accountId, siteId, context_name: context }) |
There was a problem hiding this comment.
If I'm understanding correctly based on the tests, in the absence of a context this will apply the default value which will be production meaning the current behaviour is maintained?
packages/config/src/env/main.ts
Outdated
| @@ -91,7 +99,7 @@ const getGeneralEnv = async function ({ | |||
| context, | |||
| }) { | |||
| const gitEnv = await getGitEnv(buildDir, branch) | |||
| const deployUrls = getDeployUrls({ siteInfo, branch, deployId }) | |||
| const deployUrls = getDeployUrls({ siteInfo: siteInfo as any, branch, deployId }) | |||
There was a problem hiding this comment.
I know these any's we're adding result from the untyped API but maybe we can wrap this is these nice TSFixme thingy?
There was a problem hiding this comment.
good call, done in 972ca05
JGAntunes
approved these changes
Apr 22, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're always doing an extra Envelope fetch in the CLI for
ntl build/ntl dev. We do this because@netlify/configdidn't consider the context when fetching from Envelope. Time to change that, so we can get rid that workaround in the CLI!