-
Notifications
You must be signed in to change notification settings - Fork 4
[NETOBSERV-58] Merge loki-exporter into kube-enricher #10
Conversation
imagePullPolicy: IfNotPresent | ||
name: goflow | ||
resources: | ||
limits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious why there is this limit, does that work better for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I don't put limits, I get warning in vs code. Did you installed Go & YAML extensions ?
One or more containers do not have resource limits - this could starve other processes
containers: List of containers belonging to the pod. Containers cannot currently be added or removed. There must be at least one container in a Pod. Cannot be updated.
A single application container that you want to run within a pod.
args (string[])
Arguments to the entrypoint. The docker image's CMD is used if this is not provided. Variable references $(VAR_NAME) are expanded using the container's environment. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. Cannot be updated. More info: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#running-a-command-in-a-shell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, good to know. No I haven't installed any extension for yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @jpinsonneau
(just not forget about the follow-up task for removing the json encode/decode)
are we good for merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you @jpinsonneau !
I think we can still simplify further by removing the scanner and the json encode but we can do that in a follow-up
updated go version 1.15 & dependencies versions
added vendor
configured goflow-kube.yaml
call
loki.Process
from readerStart