Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

NETOBSERV-64: integration testing #22

Merged
merged 1 commit into from
Jan 27, 2022
Merged

NETOBSERV-64: integration testing #22

merged 1 commit into from
Jan 27, 2022

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jan 26, 2022

As a previous step before modifying/optimizing the internal data deserialization process, I have created this integration testing framework that covers the whole data lifecycle, since it is received as an ecoded IPFIX message via UDP until it is forwarded as an HTTP Protobuf message to Loki.

Testing framework will grow as long as needed, and new tests will be added.

Despite the size of the PR, only 3 source files are involved. The rest are new vendored dependencies to deal with IPFIX and protobuf.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2022
@mariomac mariomac added approved no-qe This PR doesn't necessitate QE approval labels Jan 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 21645b0 into netobserv:main Jan 27, 2022
@mariomac mariomac deleted the integration branch January 27, 2022 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants