Decoupling processes and components #24
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I only had a quick look but I think it all make sense, however, since @jpinsonneau is also doing some refactoring on his side with the Kafka PoC, I'd like to make sure that this can be consistent with what he's doing and that this isn't going to be too conflicting.. @jpinsonneau what do you think? |
|
That will conflicts a lot for sure but not impossible to merge and interesting to think about ! We need to discuss about goflow2 / kube-enricher / flowlogs2metrics common parts first and decide the best architecture solution. |
|
@jpinsonneau yeah, I'm trying to refactor into a similar architecture to the pipeline you show (commiting at small steps to minimize conflicts and errors). I realized that currently it's very difficult to do any modification because goflow2 code is pretty difficult to follow and the different pipeline steps are scattered in different, distant parts of the code. |
|
@mariomac: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Superseeded by #29 |
Prior to future refactorings for optimization, the components' instantiation + initialization + main loop have been separated.
Also, the loki emitter has been removed from the "enrich" process and moved to the same level, in the read/enrich/submit loop.
Also, the whole service build is moved to a common package, so we can make sure that the main function and the integration tests use the same service structure.