Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing , after additional metrics name #505

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

msherif1234
Copy link
Contributor

Description

Add missing , after additional metrics map

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@@ -25,7 +25,7 @@ PROGRAMS='{
MAPS='{
"direct_flows":"ringbuf",
"aggregated_flows":"hash",
"additional_flow_metrics":"per_cpu_hash"
"additional_flow_metrics":"per_cpu_hash",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is JSON, could we pass the value through jq to validate the content? This would ensure:

  • The issue cannot silently reoccur
  • Any errors are surfaced earlier, perhaps with a self-test in the script itself

Untested:

echo "$MAPS" | jq empty || { echo "Invalid JSON in MAPS"; exit 1; }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good idea will add

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for PROGRAMS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah did it for both and tested in standalone script

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been:

echo "$MAPS" | jq --exit-status || { echo "Invalid JSON in MAPS"; exit 1; }

@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link

/lgtm

Copy link

openshift-ci bot commented Jan 13, 2025

@frobware: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msherif1234 msherif1234 merged commit e69154b into netobserv:main Jan 13, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants