-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing , after additional metrics name #505
Conversation
@@ -25,7 +25,7 @@ PROGRAMS='{ | |||
MAPS='{ | |||
"direct_flows":"ringbuf", | |||
"aggregated_flows":"hash", | |||
"additional_flow_metrics":"per_cpu_hash" | |||
"additional_flow_metrics":"per_cpu_hash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is JSON, could we pass the value through jq to validate the content? This would ensure:
- The issue cannot silently reoccur
- Any errors are surfaced earlier, perhaps with a self-test in the script itself
Untested:
echo "$MAPS" | jq empty || { echo "Invalid JSON in MAPS"; exit 1; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good idea will add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto for PROGRAMS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah did it for both and tested in standalone script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have been:
echo "$MAPS" | jq --exit-status || { echo "Invalid JSON in MAPS"; exit 1; }
Signed-off-by: Mohamed Mahmoud <[email protected]>
f662ac9
to
f886659
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@frobware: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Add missing
,
after additional metrics mapDependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.