search domain discovery: add whois lookup fallback #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lookup the contact information for the external public IP to derive potential search domains
marcfrei
approved these changes
Nov 12, 2024
| } | ||
| ) | ||
|
|
||
| func reverseLookupWhois(addr netip.Addr) (domains []string) { |
There was a problem hiding this comment.
Whois > WHOIS for consistency with the names of the variables above?
| return extractEmailDomains(response) | ||
| } | ||
|
|
||
| func resolveWhoisRedirects(addr netip.Addr, server string) (response string, err error) { |
| return | ||
| } | ||
|
|
||
| func queryWhois(serverTCPAddr *net.TCPAddr, queryAddr netip.Addr) (response string, err error) { |
| func queryWhois(serverTCPAddr *net.TCPAddr, queryAddr netip.Addr) (response string, err error) { | ||
| var tcpConn *net.TCPConn | ||
| var responseBuff []byte | ||
| tcpConn, err = net.DialTCP("tcp", nil, serverTCPAddr) |
There was a problem hiding this comment.
Don't we need timeouts for this operation, i.e., use net.DialTimeout plus SetDeadline on the resulting connection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallback feature for discovering a valid search domain by looking up the contact information for the external public IP and deriving potential search domains from the contact addresses.