Table: performance, prevents multiple parse of query parts by regexp (#…

…131)
nette · May 7, 2016 · e5a9b9e · Majkl578 · May 7, 2016 · norbe
1 parent 31e1b1c
commit e5a9b9e
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/src/Database/Table/GroupedSelection.php b/src/Database/Table/GroupedSelection.php
@@ -87,7 +87,7 @@ public function order($columns, ...$params)
 
 	public function aggregation($function)
 	{
-		$aggregation = & $this->getRefTable($refPath)->aggregation[$refPath . $function . $this->getSql() . json_encode($this->sqlBuilder->getParameters())];
+		$aggregation = & $this->getRefTable($refPath)->aggregation[$refPath . $function . $this->sqlBuilder->getSelectQueryHash($this->getPreviousAccessedColumns())];
 
 		if ($aggregation === NULL) {
 			$aggregation = [];

diff --git a/src/Database/Table/Selection.php b/src/Database/Table/Selection.php
@@ -677,7 +677,7 @@ protected function getSpecificCacheKey()
 			return $this->specificCacheKey;
 		}
 
-		return $this->specificCacheKey = md5($this->getSql() . json_encode($this->sqlBuilder->getParameters()));
+		return $this->specificCacheKey = $this->sqlBuilder->getSelectQueryHash($this->getPreviousAccessedColumns());
 	}
 
 

diff --git a/src/Database/Table/SqlBuilder.php b/src/Database/Table/SqlBuilder.php
@@ -136,6 +136,39 @@ public function buildDeleteQuery()
 	}
 
 
+	/**
+	 * Returns select query hash for caching.
+	 * @return string
+	 */
+	public function getSelectQueryHash($columns = NULL)
+	{
+		$parts = [
+			'delimitedTable' => $this->delimitedTable,
+			'queryCondition' => $this->buildConditions(),
+			'queryEnd' => $this->buildQueryEnd(),
+			$this->aliases,
+			$this->limit, $this->offset,
+		];
+		if ($this->select) {
+			$parts[] = $this->select;
+		} elseif ($columns) {
+			$parts[] = [$this->delimitedTable, $columns];
+		} elseif ($this->group && !$this->driver->isSupported(ISupplementalDriver::SUPPORT_SELECT_UNGROUPED_COLUMNS)) {
+			$parts[] = [$this->group];
+		} else {
+			$parts[] = "{$this->delimitedTable}.*";
+		}
+		return $this->getConditionHash(json_encode($parts), array_merge(
+			$this->parameters['select'],
+			$this->parameters['joinCondition'] ? call_user_func_array('array_merge', $this->parameters['joinCondition']) : [],
+			$this->parameters['where'],
+			$this->parameters['group'],
+			$this->parameters['having'],
+			$this->parameters['order']
+		));
+	}
+
+
 	/**
 	 * Returns SQL query.
 	 * @param  string list of columns