Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for getting specific definition #192

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Spamercz
Copy link

@Spamercz Spamercz commented Mar 22, 2019

  • new feature
  • BC break? no
  • doc PR:

There are specific addDefinition methods for each type of Definition but no getDefinition for getting specific definitions. You can only use \Nette\DI\ContainerBuilder::getDefinition with abstract return type \Nette\DI\Definitions\Definition so in your extensions you have to every time assert that you are getting right type of Definition so you can use Definition specific methods.

So I added specific Getters like \Nette\DI\ContainerBuilder::getServiceDefinition.

dg and others added 9 commits March 22, 2019 05:50
… service (nette#39)

for BC compatibility, 'class' will override 'factory'
- getServiceDefinition
- getAccessorDefinition
- getFactoryDefinition
- getLocatorDefinition
- getImportedDefinition
- in places where are specifically used methods from ServiceDefinition
- getServiceDefinition
- getAccessorDefinition
- getFactoryDefinition
- getLocatorDefinition
- getImportedDefinition
@dg dg force-pushed the master branch 7 times, most recently from 2d173ea to f6cd1c6 Compare March 26, 2019 14:49
@dg dg force-pushed the master branch 12 times, most recently from 90c07f8 to dd3170c Compare April 3, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants