-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More clear description of sendJSON() method #1061
Open
mildabre
wants to merge
47
commits into
nette:master
Choose a base branch
from
mildabre:patch-18
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Grudl <[email protected]>
dg
force-pushed
the
master
branch
8 times, most recently
from
January 13, 2025 09:53
d64ea23
to
86d9513
Compare
dg
force-pushed
the
master
branch
22 times, most recently
from
January 26, 2025 17:15
8e6ec2b
to
06f1cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose describe the function of sendJSON() method more clear, in current version is written: "Příklad action-metody, která odešle data ve formátu JSON", but the data are sent not by action method, but by sendJSON() method.
Also it is important add info, that the data are both encoded into JSON and send as http response, to avoid confusing that you should pass into the method data already encoded in JSON - small difference in meaning but important!