Switch from CMD to entrypoint #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMD runs a shell which then runs what is specified. ENTRYPOINT simply runs what is specified When K8s tries to delete a Pod, PAUSE sends SIGTERM to the running process in the container. After 30s, if the process has not exited, PAUSE sends SIGKILL. The container isn't *actually* deleted until PAUSE exits. PAUSE will exit when all its children are dead. Using CMD puts a shell between the PAUSE container and the running process. The shell doesn't properly pass on the SIGTERM. Using ENTRYPOINT removes that intermediate shell, and allows the container to exit much much faster in K8s. Signed-off-by: Ed Warnicke <[email protected]>
|
Closed in favor of #15 |
|
This is still open but the previous comment sounds like it should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMD runs a shell which then runs what is specified.
ENTRYPOINT simply runs what is specified
When K8s tries to delete a Pod, PAUSE sends SIGTERM to the
running process in the container. After 30s, if the process
has not exited, PAUSE sends SIGKILL.
The container isn't actually deleted until PAUSE exits.
PAUSE will exit when all its children are dead.
Using CMD puts a shell between the PAUSE container and the
running process. The shell doesn't properly pass on the SIGTERM.
Using ENTRYPOINT removes that intermediate shell, and allows
the container to exit much much faster in K8s.
Signed-off-by: Ed Warnicke [email protected]