Merge pull request #659 from Ex4amp1e/add-pprof-enable-conf

Update configuration for turning profiling on/off
networkservicemesh · Aug 14, 2024 · d8c2e3b · d8c2e3b
2 parents b94f5a2 + edab9cd
commit d8c2e3b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -27,6 +27,8 @@ docker build .
 * `NSM_LOG_LEVEL`                - Log level (default: "INFO")
 * `NSM_OPEN_TELEMETRY_ENDPOINT`  - OpenTelemetry Collector Endpoint (default: "otel-collector.observability.svc.cluster.local:4317")
 * `NSM_METRICS_EXPORT_INTERVAL`  - interval between mertics exports (default: "10s")
+* `NSM_PPROF_ENABLED`            - is pprof enabled (default: "false")
+* `NSM_PPROF_LISTEN_ON`          - pprof URL to ListenAndServe (default: "localhost:6060")
 
 # Testing
 

diff --git a/main.go b/main.go
@@ -54,6 +54,7 @@ import (
 	"github.com/networkservicemesh/sdk/pkg/tools/grpcutils"
 	"github.com/networkservicemesh/sdk/pkg/tools/log"
 	"github.com/networkservicemesh/sdk/pkg/tools/log/logruslogger"
+	"github.com/networkservicemesh/sdk/pkg/tools/pprofutils"
 )
 
 // Config is configuration for cmd-registry-proxy-dns
@@ -65,6 +66,8 @@ type Config struct {
 	LogLevel               string        `default:"INFO" desc:"Log level" split_words:"true"`
 	OpenTelemetryEndpoint  string        `default:"otel-collector.observability.svc.cluster.local:4317" desc:"OpenTelemetry Collector Endpoint" split_words:"true"`
 	MetricsExportInterval  time.Duration `default:"10s" desc:"interval between mertics exports" split_words:"true"`
+	PprofEnabled           bool          `default:"false" desc:"is pprof enabled" split_words:"true"`
+	PprofListenOn          string        `default:"localhost:6060" desc:"pprof URL to ListenAndServe" split_words:"true"`
 }
 
 func main() {
@@ -120,6 +123,11 @@ func main() {
 			}
 		}()
 	}
+
+	if config.PprofEnabled {
+		go pprofutils.ListenAndServe(ctx, config.PprofListenOn)
+	}
+
 	// Get a X509Source
 	source, err := workloadapi.NewX509Source(ctx)
 	if err != nil {

diff --git a/pkg/imports/imports_linux.go b/pkg/imports/imports_linux.go
@@ -16,6 +16,7 @@ import (
 	_ "github.com/networkservicemesh/sdk/pkg/tools/log"
 	_ "github.com/networkservicemesh/sdk/pkg/tools/log/logruslogger"
 	_ "github.com/networkservicemesh/sdk/pkg/tools/opentelemetry"
+	_ "github.com/networkservicemesh/sdk/pkg/tools/pprofutils"
 	_ "github.com/networkservicemesh/sdk/pkg/tools/spiffejwt"
 	_ "github.com/networkservicemesh/sdk/pkg/tools/spire"
 	_ "github.com/networkservicemesh/sdk/pkg/tools/token"