Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NormalizeExact instead of Normalize #57

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

xervon
Copy link
Contributor

@xervon xervon commented Jun 18, 2023

Fixes #49

NormalizeExact returns a string slice. This change just chooses the first returned host. This is also what Normalize does.

@denis-tingaikin
Copy link
Member

Could you please fix CI issues?

Signed-off-by: Mika Dede <[email protected]>
@denis-tingaikin denis-tingaikin merged commit 3cd285d into networkservicemesh:main Aug 20, 2024
13 checks passed
@denis-tingaikin
Copy link
Member

@xervon Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bringing attention to the use of the Normalize function which is being deprecated
2 participants