Rework creation of route tables #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
requested review from
glazychev-art,
denis-tingaikin,
Chunosov,
edwarnicke and
LionelJouin
LionelJouin
reviewed
Mar 22, 2022
| @@ -54,19 +53,28 @@ func create(ctx context.Context, conn *networkservice.Connection, tableIDs *Map, | |||
| return errors.WithStack(err) | |||
| } | |||
|
|
|||
| tableMap, ok := tableMaps.Load(conn.NetworkServiceEndpointName) | |||
There was a problem hiding this comment.
If a NSC is connected to 2 NSEs, there might be a conflict since the counter will be separated for the 2 connections. A policy for NSE-1 will create a table and rule with table ID 1, and another policy for NSE-2 will select the same table ID.
I suggest to use the NET NS URL as key instead. I have proposed this change in this PR: #433
NikitaSkrynnik
force-pushed
the
fix-iprule
branch
from
15a72e7
to
0ca41e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Skrynnik [email protected]
Issue
networkservicemesh/integration-k8s-kind#610