Add routerlocalnet server chain element #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwarnicke
reviewed
May 10, 2022
|
|
||
| mechanism := kernel.ToMechanism(request.GetConnection().GetMechanism()) | ||
| if mechanism != nil && mechanism.GetRouteLocalNet() { | ||
| err := enableRouteLocalNet(mechanism.GetInterfaceName()) |
There was a problem hiding this comment.
Could we inline enableRouteLocalNet here. Its pretty simple, and then one can scan a single simple function rather than having to change context to the function.
Signed-off-by: Sergey Shlyanin <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
May 10, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#465 Commit: 127617b Author: Ed Warnicke Date: 2022-05-10 09:08:29 -0500 Message: - Merge pull request #465 from rejmond/issue-464 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
May 10, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#465 Commit: 127617b Author: Ed Warnicke Date: 2022-05-10 09:08:29 -0500 Message: - Merge pull request #465 from rejmond/issue-464 Signed-off-by: NSMBot <[email protected]>
This was referenced May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Shlyanin [email protected]
Issue
#464