Feature improvements for upslog
#2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tuple logging specs together Signed-off-by: Jim Klimov <[email protected]>
…aracter can now be used in the formatting string Signed-off-by: Jim Klimov <[email protected]>
…%UPSHOST%` when multiple systems are being logged Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…ow safely be used in different logging tuples Signed-off-by: Jim Klimov <[email protected]>
…gging (and foregrounding by default), like with other NUT daemons Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
|
❌ Build nut 2.8.2.2605-master failed (commit 4be6b9824f by @jimklimov) |
…ame to query for currently served devices Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…ut attempts Signed-off-by: Jim Klimov <[email protected]>
|
✅ Build nut 2.8.2.2606-master completed (commit d2951f58af by @jimklimov) |
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
|
CI faults unrelated to the changes: CodeQL workers apparently got a clang update and a new wad of warnings to older code base. |
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
the
refactor/fightwarn
…#823] New checks in clang-18/19 brought new findings, some of them reasonable :) * "%x" style formatting requires an (unsigned int) variable * numeric literals and macros are (int) by default * results of math with (uint16_t), done in some cases, are upscaled into (int) by default * char, unsigned or not, seems to be also upscaled into (int) Overall, had to change formatting strings in some cases, variable types in others (e.g. flags or notification types do not make sense as signed) and added casting in a few places that remained. Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…PRECATED_DECLARATIONS detection Signed-off-by: Jim Klimov <[email protected]>
…ARATIONS for new clang-19 Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…CONVERT_GITHUB_LINKS that were not re-used into a single block of code Helps against docs/Makefile.am: warning: escaping \# comment markers is not portable Fix inspired by ddclient/ddclient#745 Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per NEWS:
-s <system>and-l <logfile>) along with newer tuple(s) for multiple-system logging (repeatable-m <system,logfile>), previously the single-system options were overridden by the tuple(s); now they become part of the list.upsnamein thesystem=upsname[@hostname[:port]]parameter may be an asterisk*to query for devices currently served by the hostname.%UPSHOST%in a custom formatting string).%UPSHOST%when multiple systems are being logged.%tfor a TAB character can now be used in the formatting string.-Dfor debugging (and foregrounding by default), like with other NUT daemons.Also addresses warnings of new clang-19 because GH builders began using it.
UPDATE: See also #2762 for some more improvements, internal and externally usable.