Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentence Filter after corpus reading #528

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sentence Filter after corpus reading #528

wants to merge 7 commits into from

Conversation

gmwe
Copy link
Contributor

@gmwe gmwe commented Aug 24, 2018

Added the ability to apply sentence filters after reading the corpus (Not just as a preprocessing step).
example usage:

train: !SimpleTrainingRegimen
  sent_filter: !SentenceFiltererMatchingRegex
    spec:
      regex_trg: '^[^\(\)]*$'

@msperber
Copy link
Contributor

Looks good to me, but it seems unit tests are currently failing?

@neubig
Copy link
Contributor

neubig commented Aug 27, 2018

Should sentence filtering be under "train" directly? It seems like maybe it should be a function of the readers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmwe @msperber @neubig