[Text Generation][Fix] Assert that tokens have the same shape on output
#1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mian/fix_stochastic
…uralmagic/deepsparse into feature/damian/fix_stochastic
This reverts commit 8234524.
…uralmagic/deepsparse into feature/damian/fix_stochastic
shubhra
approved these changes
Jul 26, 2023
bfineran
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
deterministic=False, it is possible that generated sequences from different batches end up having different token lengths. They need to be padded to the length of the longest returned sequence (similarly to how we are already treating the logits).Note: this PR is blocked by #1128 and #1120.