✨Deepsparse Backend implementation #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 26, 2024 14:28
* settings.py::DeepsparseSettings includes all the settings * tests/unit/backend/deepsparse.py includes unit tests * `TestTextGenerationPipeline` mocks the `deepsparse.pipeline.Pipeline`
parfeniukink
changed the title
mgoin
reviewed
Aug 28, 2024
Comment on lines
3
to
4
| from deepsparse import Pipeline | ||
| from deepsparse import Pipeline, TextGeneration |
There was a problem hiding this comment.
Does this mean deepsparse is a dep of guidellm? We should keep it optional at most IMO, so could this be in a try catch with an informational message to install?
There was a problem hiding this comment.
So, since the backend/deepsparse/__init__.py exists we determine it as a module so before you reach the deepsparse/backend.py you are going to run such a validation.
Also, all the imports are like from guidellm.backend import Backend, BackendEngine but if you need the deepsparse just from .guidellm.backend.deepsparse import DeepsparseBackend which runs this validation.
Also the deepsparse is an optional dependency. At least it is in optional section
added 14 commits
August 28, 2024 17:06
* `DeepsparseSettings` is completely removed
`backend.DeepsparseBackend` -> `backend.deepsparse.DeepsparseBackend`
parfeniukink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Deepsparse Backend interface is implemented.
pyproject.tomlfilerufferrors are suppressedDeepsparseBackendgets configurations from CLI, environment or defaultssettings.py::DeepsparseSettingsincludes all the settingstests/unit/backend/deepsparse.pyincludes unit testsTestTextGenerationPipelinemocks thedeepsparse.pipeline.PipelineUsage
This is an example of a command you can use in your terminal:
--data=openai_humaneval: determines the dataset--model=/local/path/my_model: determines the local path to the model object. If not specified - the env variable will be used.Environment configuration
The model could also be set with
GUIDELLM__LLM_MODEL. If the CLI value or environment variable is not set, then the default will be used. Currently, the default model is:mistralai/Mistral-7B-Instruct-v0.3.