[Feature Branch] Quant modifier UX #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
force-pushed
the
quant-modifier-ux
branch
3 times, most recently
from
dfb3d7f
to
a55f50c
Compare
rahul-tuli
requested review from
Satrat,
bfineran,
dsikka,
horheynm and
dbogunowicz
rahul-tuli
changed the title
rahul-tuli
force-pushed
the
quant-modifier-ux
branch
from
5b88ad3
to
4230fb7
Compare
Make sparsegpt not inherit from wanda modifier Decouple SparseGPTModifierPyTorch from WandaPruningModifier Fix docstrings
rahul-tuli
force-pushed
the
quant-modifier-ux
branch
from
4230fb7
to
d4d85ff
Compare
* Update OBCQ * Extract GPTQ Modifier
…antization (#2294) * Update OBCQ * Extract GPTQ Modifier * Update test recipes
* Update OBCQ * Extract GPTQ Modifier * Update test recipes * Add config_groups support to GPTQModifier * mask_structure preservation test (#2284) * test * Preserve weight sparsity if greater than threshold * Add argument to preserve sparsity mask in SPARSEGPT * fix case when mask is none * Add test to check mask_structure - initial mask structure should be preserved b/w consecutive runs; added test to check this * Update tensor_follows_mask_structure to check for atleast n zeros --------- Co-authored-by: Sara Adkins <[email protected]> * PR comments --------- Co-authored-by: Sara Adkins <[email protected]>
bfineran
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantization Modifier UX Update
Description
This PR refactors the quantization modifiers to enhance user experience and simplify the system architecture. It is based off of changes from
thesa/quant_mod_refactormainbranch, all subsequent changes will be merged as smaller bites sized PRs into this. Key updates include:WandaandSparseGPT#2266Reference Documentation
For more detailed information about the changes and their impact, please refer to the documentation here.