[Cherry Picks] Analyze Bug Fixes (Updated) #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Satrat
commented
Feb 22, 2024
Satrat
commented
- op analysis total counts had double sparse counts #461
- Fixing Quant % Calcuation #462
- Include Sparsity in Size Calculation #463
* initial commit * add docstrings * simplify * hardening * refactor * format registry lookup strings to be lowercases * standardise aliases
…ata.1` if only one external data file gets eventually saved (#414)
Add test
* add support for benchmark.yaml recent zoo models use `benchmark.yaml` instead of `benchmarks.yaml`. adding this additional pathway so `benchmark.yaml` is downloaded in the bulk model download * update files filter * fix tests --------- Co-authored-by: dbogunowicz <[email protected]>
* Add analyze to init * Move onnxruntime to deps * Print model analysis (#423) * [model.download] fix function returning nothing (#420) * [BugFix] Path not expanded (#418) * print model-analysis * [Fix] Allow for processing Path in the sparsezoo analysis (#417) * add print statement at the end of cli run --------- Co-authored-by: Dipika Sikka <[email protected]> Co-authored-by: Rahul Tuli <[email protected]> Co-authored-by: dbogunowicz <[email protected]> * Omit scalar weight (#424) * ommit scalar weights: * remove unwanted files * comment * Update src/sparsezoo/utils/onnx/analysis.py Co-authored-by: Benjamin Fineran <[email protected]> --------- Co-authored-by: Benjamin Fineran <[email protected]> --------- Co-authored-by: George <[email protected]> Co-authored-by: Dipika Sikka <[email protected]> Co-authored-by: dbogunowicz <[email protected]> Co-authored-by: Benjamin Fineran <[email protected]>
…437) * fix analyze to work with larger models * update for failing tests; add comments * Update src/sparsezoo/utils/onnx/external_data.py Co-authored-by: dbogunowicz <[email protected]> --------- Co-authored-by: Dipika Sikka <[email protected]> Co-authored-by: dbogunowicz <[email protected]>
* Download deployment dir for llms * Use path instead of download
* chunk download, break down into 10 * lint * threads download * draft * chunk download draft * job based download and combining/deleteing chunks * delete old code * lint * fix num jobs if file_size is less than the chunk size * doc string and return types * test * lint
* fix equivalent changes made to analyze_v2 such that inference session works for llms; update wanrings to be debug printouts * typo
Co-authored-by: 21 <[email protected]>
Avoid log of zero
* initial fix * style
* initial fix * style * incorporate sparsity into size calculation * quality
* initial fix * style
* initial fix * style * incorporate sparsity into size calculation * quality
bfineran
approved these changes
Feb 22, 2024
rahul-tuli
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.