Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk download folder and threads change #469

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Chunk download folder and threads change #469

merged 1 commit into from
Feb 28, 2024

Conversation

horheynm
Copy link
Member

@horheynm horheynm commented Feb 28, 2024 •
edited
Loading

Fixes

  • Each file that is downloading in chunks have its own chunk file- not shared bc completion of one deletes the downloading path of the second file if running in parallel
  • Number of threads to be guaranteed to work
  • Better tdqm message. Before Downloading Chunks after Downloading Chunks for config.json

@bfineran bfineran merged commit 3b97dfc into main Feb 28, 2024
3 of 4 checks passed
@bfineran bfineran deleted the download-iso-chunk-folder branch February 28, 2024 16:28
horheynm added a commit that referenced this pull request Feb 29, 2024
@horheynm
add more info on what chunk is downloading, and make chunk folder foe…
943d679 
… each file (#469)
bfineran pushed a commit that referenced this pull request Feb 29, 2024
@horheynm @rahul-tuli
Cp chunk download (#471)
3e9e322 
* add more info on what chunk is downloading, and make chunk folder foe each file (#469)

* Download iso chunk folder (#470)

* add more info on what chunk is downloading, and make chunk folder foe each file

* fix bug

* comments

* add .cache/sparsezoo/neuralmagic/

---------

Co-authored-by: Rahul Tuli <[email protected]>
bfineran pushed a commit that referenced this pull request Mar 8, 2024
@horheynm
Cp download parallel (#477)
0b58962 
* add more info on what chunk is downloading, and make chunk folder foe each file (#469)

* Download iso chunk folder (#470)

* add more info on what chunk is downloading, and make chunk folder foe each file

* fix bug

* comments

* add .cache/sparsezoo/neuralmagic/

* Multiple download bug (#476)

* src/sparsezoo/utils/download.py

* revert readme"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horheynm @bfineran