Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bayesian Hyperparameter tuning for all DN on Audition tasks (Issue #31) #66

Merged
merged 30 commits into from
Aug 1, 2022

Conversation

adwaykanhere
Copy link
Contributor

@adwaykanhere adwaykanhere commented May 15, 2022

This PR will address part of Issue #31 and have the following changes:

  • Closed adding Bayesian hyperparameter tuning of the Audition data using Pytorch's Ax library and Raytune.
  • Fixed adding a separate file- fsdk18preprocess.py for all preprocessing steps required to run DN benchmarks on audition. This is necessary to run fsdk18.py and fsdk18tuning.py scripts.
  • Ensured that the ratio of sample sizes for audition is consistently 2:1:1 for all the class combinations when running benchmarks with and without tuning.
  • Resolved to remove any unnecessary functions in the audition toolbox

Library conflicts:
Raytune needs to be version 1.11.0 and not later

@netlify
Copy link

netlify bot commented May 15, 2022

Deploy Preview for dfdn canceled.

Name Link
🔨 Latest commit 5df413e
🔍 Latest deploy log https://app.netlify.com/sites/dfdn/deploys/628288953cd88900084f4f52

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to optimize the requirements and dependencies. Why removing the versions?

Say if script A imports package I, and script B imports script A, then script B should not import package I. Remove the duplications to make the code more robust.

Additionally, I don't see why there's an fsd18k and an fsd18ktuning. Leave the updated one and name it fsd18k.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fsdk18preprocess is not necessary as a separate file. Put the function inside toolbox.

@adwaykanhere
Copy link
Contributor Author

all changes updated

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you downgraded opencv-python and use a different format for torch packages (checks not passed). Also there is no sklearn pacakge name in pip.

@adwaykanhere
Copy link
Contributor Author

Sorry, the changes have been fixed.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use botorch at all?

@adwaykanhere
Copy link
Contributor Author

Botorch is a requirement for Ax. Reference

@PSSF23 PSSF23 changed the base branch from main to audio August 1, 2022 13:15
@PSSF23 PSSF23 merged commit 193a059 into neurodata:audio Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants