-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Bayesian Hyperparameter tuning for all DN on Audition tasks (Issue #31) #66
Conversation
✅ Deploy Preview for dfdn canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to optimize the requirements and dependencies. Why removing the versions?
Say if script A imports package I, and script B imports script A, then script B should not import package I. Remove the duplications to make the code more robust.
Additionally, I don't see why there's an fsd18k
and an fsd18ktuning
. Leave the updated one and name it fsd18k
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fsdk18preprocess
is not necessary as a separate file. Put the function inside toolbox
.
all changes updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you downgraded opencv-python
and use a different format for torch
packages (checks not passed). Also there is no sklearn
pacakge name in pip
.
Sorry, the changes have been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you use botorch
at all?
Botorch is a requirement for Ax. Reference |
This PR will address part of Issue #31 and have the following changes:
Library conflicts:
Raytune needs to be version 1.11.0 and not later