-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace brainglobe-utils
with qt-niu
#441
Open
lochhh
wants to merge
18
commits into
napari-dev
Choose a base branch
from
use-qt-niu
base: napari-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+225
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sfmig <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## napari-dev #441 +/- ##
===========================================
Coverage 99.82% 99.82%
===========================================
Files 18 18
Lines 1122 1175 +53
===========================================
+ Hits 1120 1173 +53
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chang Huan Lo <[email protected]>
for more information, see https://pre-commit.ci
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Following brainglobe/brainglobe-utils#107 (comment),
this PR replaces the obsolete
brainglobe-utils
dependency withqt-niu
How has this PR been tested?
This PR was tested while following the napari guide in PR #393.
Note
This PR is branched off PR #393 / (https://github.com/neuroinformatics-unit/movement/tree/document-napari-plugin)
Checklist: