Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace brainglobe-utils with qt-niu #441

Open
wants to merge 18 commits into
base: napari-dev
Choose a base branch
from
Open

Replace brainglobe-utils with qt-niu #441

wants to merge 18 commits into from

Conversation

lochhh
Copy link
Collaborator

@lochhh lochhh commented Feb 25, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Following brainglobe/brainglobe-utils#107 (comment),
this PR replaces the obsolete brainglobe-utils dependency with qt-niu

How has this PR been tested?

This PR was tested while following the napari guide in PR #393.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@lochhh lochhh changed the base branch from main to napari-dev February 25, 2025 15:24
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (5d5e5ed) to head (8cb302f).
Report is 10 commits behind head on napari-dev.

Additional details and impacted files
@@             Coverage Diff             @@
##           napari-dev     #441   +/-   ##
===========================================
  Coverage       99.82%   99.82%           
===========================================
  Files              18       18           
  Lines            1122     1175   +53     
===========================================
+ Hits             1120     1173   +53     
  Misses              2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochhh lochhh marked this pull request as ready for review February 25, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants