Syncing #272
Closed
Syncing #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subtracting y from the number of rows: 260
add EBSSA dataset
Representative of a basic header as observed on Aedat 2.0 files obtained from jAER.
(Attempted) made it compatible with the uploaded sample aedat2.0 file.
Added assertion for the third return value (start_timestamp), based on the sample file uploaded (aedat2.0).
Have adjusted data_start according to the file I'm feeding. However, I'm not sure if the sample file is useful. I've not been using it so far. So the assertion may not be serving its purpose at the moment.
no assertions, just added another return value for the same function (read from aedat function) with the previously available test with aedat4 file.
just removed the start index assertion because I noticed the returned value is different for different systems (598 in some, 610 in some as observed in previous pytest feedback).
Missed out on updating comments.
…the relative timestamps with a seperate start_time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.