Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limit inttests #347
Rate limit inttests #347
Changes from 9 commits
dcef714
6b6b634
e0c5a1b
ee8b133
8247b95
5e49fc6
ad40ad9
f070a06
5e516f8
f1147a4
7a53a72
bee8ea8
2ebf08f
adaf55a
08f6d33
05dadb4
f777034
10b1869
75d327f
000d45a
e42fe5c
385b3b5
ecf0f7c
db3f971
a5aaa27
3f43c19
cfaa50b
e721578
da6674c
25c7721
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? because of computation increase during packet_recv and packet_send handlers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, otherwise during
ibc_transfer
test contract isn't refunded because of out of gasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's got required to increase the multiplier because of a poor simulation process or because the IBC transactions reached the ceiling of
max_gas = 3000000
. if the latter, why don't increase themax_gas
instead of the multiplier? would be cleaner