chore: NTRN-288: use websocket to wait for new block #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxpy
force-pushed
the
chore/NTRN-288-wait-for-new-block-websocket
branch
4 times, most recently
from
3942479
to
c0b1fae
Compare
foxpy
force-pushed
the
chore/NTRN-288-wait-for-new-block-websocket
branch
2 times, most recently
from
fd74c90
to
5cdd69b
Compare
sotnikov-s
reviewed
Jan 12, 2023
foxpy
force-pushed
the
chore/NTRN-288-wait-for-new-block-websocket
branch
from
5cdd69b
to
5a88673
Compare
foxpy
force-pushed
the
chore/NTRN-288-wait-for-new-block-websocket
branch
2 times, most recently
from
9990285
to
cc02750
Compare
Previous behaviour used to be HTTP polling busy loop.
foxpy
force-pushed
the
chore/NTRN-288-wait-for-new-block-websocket
branch
from
cc02750
to
6210a02
Compare
ratik
reviewed
Jan 17, 2023
src/helpers/wait.ts
Outdated
| } | ||
| }; | ||
|
|
||
| waitBlocks(n: number) { |
There was a problem hiding this comment.
Suggested change
| waitBlocks(n: number) { | |
| waitBlocks(n: number, timeout=120000): Promise<void> { |
ratik
reviewed
Jan 17, 2023
sotnikov-s
reviewed
Jan 17, 2023
ratik
approved these changes
Jan 17, 2023
sotnikov-s
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour used to be HTTP polling busy loop.
[NTRN-288] [Test run]