feat: clean bindings #ntrn-410 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
force-pushed
the
feat/clean-bindings
branch
from
d963527
to
7d038b7
Compare
NeverHappened
force-pushed
the
feat/clean-bindings
branch
from
7d038b7
to
9791793
Compare
NeverHappened
force-pushed
the
feat/clean-bindings
branch
from
8e1ef0e
to
ba8de0c
Compare
NeverHappened
force-pushed
the
feat/clean-bindings
branch
from
a103055
to
08b4e76
Compare
This was referenced Oct 16, 2024
pr0n00gler
requested changes
Oct 21, 2024
packages/neutron-sdk/src/lib.rs
Outdated
| @@ -3,22 +3,18 @@ | |||
| // #![forbid(unsafe_code)] | |||
| #![warn(trivial_casts, trivial_numeric_casts, unused_import_braces)] | |||
|
|
|||
| // TODO: can we get it from other place? or move NEUTRON_COMMIT to other place | |||
| // TODO: do we need NEUTROND_VERSION? | |||
There was a problem hiding this comment.
I don't think we need this constant anymore, since we are not building proto files here now
sotnikov-s
requested changes
Oct 27, 2024
contracts/neutron_interchain_queries/src/testing/mock_querier.rs
Outdated
Show resolved
Hide resolved
sotnikov-s
previously approved these changes
Oct 29, 2024
sotnikov-s
previously approved these changes
Oct 30, 2024
pr0n00gler
previously approved these changes
Oct 31, 2024
NeverHappened
dismissed stale reviews from pr0n00gler and sotnikov-s
via
5935e3f
pr0n00gler
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove bindings and related code from neutron-sdk ,neutron-dev-contracts and integration tests
https://hadronlabs.atlassian.net/browse/NTRN-410
PR's: