Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip install work with new version of setuptools #17

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

backmari
Copy link
Contributor

Installing using pip install is failing with error messages like:

_MissingDynamic: license defined outside of pyproject.toml is ignored.

This seems related to a new release of setuptools: https://stackoverflow.com/a/77527178

This PR changes pyproject.toml to follow current standards to be able to do pip install.

To test, make sure that pip install works and that the package metadata is shown as expected, especially the dynamic metadata that is pulled from setup.cfg.

$ pip install -e .
...
$ pip show --verbose LiquidsReflectometer
Name: LiquidsReflectometer
Version: 2.0.13
Summary: Reduction scripts for the Liquids Reflectometer. This includes both automated reduction scripts and useful scripts to reprocess data.
Home-page: https://github.com/neutrons/LiquidsReflectometer
Author: Mat
Author-email: [email protected]
License: BSD 3-Clause License
Location: /home/u5z/mambaforge/envs/liqref/lib/python3.8/site-packages
Editable project location: /home/u5z/projects/LiquidsReflectometer
Requires: lmfit, mantidworkbench, matplotlib, numpy
Required-by: 
Metadata-Version: 2.1
Installer: pip
Classifiers:
  Operating System :: OS Independent
  Programming Language :: Python :: 3
Entry-points:
Project-URLs:

@jmborr jmborr self-requested a review November 29, 2023 17:29
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@backmari backmari merged commit 806827a into master Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants