Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include error events in dead time correction #25

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Include error events in dead time correction #25

merged 4 commits into from
Mar 25, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Mar 20, 2024 •
edited
Loading

  • Read in error events when computing correction
  • Add test [mainly check that old ones still work since results should be similar]
  • Should use Mantid >= 6.9.20240318.1114

@mdoucet mdoucet requested a review from jmborr March 25, 2024 15:16
jmborr
jmborr approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@mdoucet mdoucet merged commit e39b267 into master Mar 25, 2024
1 check passed
@mdoucet mdoucet deleted the dt_err_event branch March 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmborr jmborr jmborr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdoucet @jmborr