-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for const Q binning per run #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #134 +/- ##
==========================================
+ Coverage 60.45% 62.44% +1.98%
==========================================
Files 121 122 +1
Lines 10139 10191 +52
==========================================
+ Hits 6130 6364 +234
+ Misses 4009 3827 -182 ☔ View full report in Codecov by Sentry. |
328cb9d
to
7d68d7e
Compare
jmborr
requested changes
Dec 3, 2024
RefRed/autopopulatemaintable/populate_reduction_table_from_list_lrdata.py
Outdated
Show resolved
Hide resolved
RefRed/configuration/load_reduction_table_from_lconfigdataset.py
Outdated
Show resolved
Hide resolved
jmborr
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Add new option to enable reduction in constant Q binning, which is a reduction option in lr_reduction method
process_from_template
. The option is added as a new column in the reduction table: "Const. Q Bin." and is thus configurable per run.This change also consolidates logic that updates/clears the reduction table into the class
ReductionTableHandler
.Check all that apply:
Added integration testsVerified that tests requiring the /SNS and /HFIR filesystems pass without failReferences:
Manual test for the reviewer
(instructions to set up the environment)
Start RefRed GUI
Or run tests
(refred)> pytest test/unit/RefRed/test_main.py
Manual tests:
Check list for the reviewer