Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyre.unit incorporation #7

Merged
merged 4 commits into from
Nov 18, 2024
Merged

pyre.unit incorporation #7

merged 4 commits into from
Nov 18, 2024

Conversation

KyleQianliMa
Copy link
Collaborator

@KyleQianliMa KyleQianliMa commented Nov 18, 2024

Short description of the changes:

Replace pyre.unit with histogram unit in the utils.unit directory. This eliminates the need of pyre.unit dependency.
IBM Story 7535

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

Simpy pull the new branch and pytest all tests should pass

References

@KyleQianliMa KyleQianliMa requested a review from mpatrou November 18, 2024 18:47
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 89.00804% with 41 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (7a74f35) to head (7bb849e).

Files with missing lines Patch % Lines
src/histogram/utils/units/unit.py 70.63% 37 Missing ⚠️
src/histogram/utils/units/unitparser.py 92.10% 3 Missing ⚠️
src/histogram/utils/Singleton.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next       #7      +/-   ##
==========================================
+ Coverage   76.97%   78.23%   +1.25%     
==========================================
  Files          42       61      +19     
  Lines        3175     3547     +372     
==========================================
+ Hits         2444     2775     +331     
- Misses        731      772      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@KyleQianliMa KyleQianliMa changed the base branch from main to next November 18, 2024 18:51
@KyleQianliMa KyleQianliMa changed the base branch from next to main November 18, 2024 18:55
@KyleQianliMa KyleQianliMa changed the base branch from main to qa November 18, 2024 18:55
@KyleQianliMa KyleQianliMa changed the base branch from qa to next November 18, 2024 18:55
@@ -0,0 +1,51 @@
# -*- Makefile -*-
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Make.mm needed? We can omit it


# implementation of the Parser singleton

from pyre.util.Singleton import Singleton
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need this file too

Copy link
Collaborator

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass locally. it looks good to me!!

@KyleQianliMa KyleQianliMa merged commit f257789 into next Nov 18, 2024
3 checks passed
@KyleQianliMa KyleQianliMa deleted the pyre_removal branch November 18, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants