-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyre.unit incorporation #7
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #7 +/- ##
==========================================
+ Coverage 76.97% 78.23% +1.25%
==========================================
Files 42 61 +19
Lines 3175 3547 +372
==========================================
+ Hits 2444 2775 +331
- Misses 731 772 +41 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
src/histogram/utils/units/Make.mm
Outdated
@@ -0,0 +1,51 @@ | |||
# -*- Makefile -*- | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the Make.mm needed? We can omit it
|
||
# implementation of the Parser singleton | ||
|
||
from pyre.util.Singleton import Singleton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would need this file too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests pass locally. it looks good to me!!
Short description of the changes:
Replace pyre.unit with histogram unit in the utils.unit directory. This eliminates the need of pyre.unit dependency.
IBM Story 7535
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
Simpy pull the new branch and pytest all tests should pass
References