Run python 2->3 and fix tests #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
force-pushed
the
py2to3
branch
from
f2cfa4a
to
f900dba
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 63.36% 62.96% -0.40%
==========================================
Files 14 14
Lines 1152 1145 -7
==========================================
- Hits 730 721 -9
- Misses 422 424 +2 ☔ View full report in Codecov by Sentry. |
This reverts commit fbac0d4.
backmari
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only moving to python 3.6 for now because stompest doesn't support > python 3.6. Once we replace stompest we can move to a newer python version.
Ref 3200