-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use unused filled chemmaster sprite #2729
use unused filled chemmaster sprite #2729
Conversation
Resources/Prototypes/Entities/Structures/Machines/chem_master.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works a treat.
I see what you did and why, and I remember doing that when I originally did this in the chemprentice PR. But I am extremely puzzled as to why it worked properly in my testing for the PR without that mapping in place |
but that's a question for another time I suppose, even if it somehow autolinked due to the shared state reference, it is still best practice for clarity to specifically map it to a layer. |
You seem to have had it here before, and this new branch didn't show the screen under test. |
Resources/Prototypes/Entities/Structures/Machines/chem_master.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Structures/Machines/chem_master.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Structures/Machines/chem_master.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Structures/Machines/chem_master.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Dvir <[email protected]>
Co-authored-by: Dvir <[email protected]>
Co-authored-by: Dvir <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
About the PR
Now the chemmaster shows a different sprite when it has a beaker!
Why / Balance
unused sprite was languishing in the code, bring it in and warm it up
How to test
put beaker in chemmaster
Media
Requirements
Breaking changes
Changelog
🆑