-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing captain items in loadouts #2787
base: master
Are you sure you want to change the base?
Conversation
Added some missing captain clothing to the loadouts Moved a few things, changed most captain clothes to T2 and changed some prices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine on the face of it, a few points of cleanup requested.
@@ -339,16 +339,16 @@ | |||
effects: | |||
- !type:GroupLoadoutEffect | |||
proto: ContractorT3 | |||
price: 2500 | |||
price: 1500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
price: 1500 | |
price: 2500 |
Revert. If T3 items cost 2500, and this is a T3 item, it should cost 2500.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the cloaks are a bit expensive, but I guess that's an issue for another PR
Also, aren't the T1, T2, T3 only meant as time requirements ? It seems a bit odd to me that they have to cost more just because they're "higher tier"
- type: loadout | ||
id: ContractorClothingNeckMantleCap | ||
effects: | ||
- !type:GroupLoadoutEffect | ||
proto: ContractorT3 | ||
price: 2500 | ||
proto: ContractorT2 | ||
price: 1000 | ||
equipment: | ||
neck: ClothingNeckMantleCap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is T2, move it to the T2 section.
- type: loadout | ||
id: ContractorClothingUniformJumpsuitCapFormal | ||
effects: | ||
- !type:GroupLoadoutEffect | ||
proto: ContractorT3 | ||
hideEffects: | ||
- !type:GroupLoadoutEffect | ||
proto: PantsCapableNF | ||
price: 1500 | ||
equipment: | ||
jumpsuit: ClothingUniformJumpsuitCapFormal | ||
|
||
- type: loadout | ||
id: ContractorClothingUniformJumpskirtCapFormalDress | ||
effects: | ||
- !type:GroupLoadoutEffect | ||
proto: ContractorT3 | ||
hideEffects: | ||
- !type:GroupLoadoutEffect | ||
proto: PantsCapableNF | ||
price: 1500 | ||
equipment: | ||
jumpsuit: ClothingUniformJumpskirtCapFormalDress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tier of item, denote as separate with a comment (see "# T3 "Military" below)
effects: | ||
- !type:GroupLoadoutEffect | ||
proto: ContractorT2 | ||
price: 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
price: 1000 | |
price: 1250 |
Consistency.
effects: | ||
- !type:GroupLoadoutEffect | ||
proto: ContractorT2 | ||
price: 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
price: 1000 | |
price: 1250 |
Consistency.
- type: loadout | ||
id: ContractorClothingHandsGlovesCaptain | ||
effects: | ||
- !type:GroupLoadoutEffect | ||
proto: ContractorT2 | ||
price: 1000 | ||
equipment: | ||
gloves: ClothingHandsGlovesCaptain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are in approximate order of value, reorder after the boxing gloves.
@@ -580,6 +586,7 @@ | |||
- ContractorClothingHandsGlovesColorOrange | |||
- ContractorClothingHandsGlovesColorPurple | |||
- ContractorClothingHandsGlovesColorRed | |||
- ContractorClothingHandsGlovesCaptain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reorder after the boxing gloves to be in increasing order of value.
About the PR
Added the following items to loadouts
Contractor loadout:
Mercenary loadout:
Changed some of the time requirements/prices for better consistency
Why / Balance
How to test
Check the contractor loadout (head, neck, jumpsuit, gloves, belt) and the mercenary loadout (outer clothing)
Media
Requirements
Breaking changes
Changelog
🆑