Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing captain items in loadouts #2787

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Bonaout
Copy link
Contributor

@Bonaout Bonaout commented Jan 25, 2025

About the PR

Added the following items to loadouts

Contractor loadout:

  • Captain's hardhat
  • Captain's jumpsuit
  • Captain's jumpskirt
  • Captain's formal suit
  • Captain's formal dress
  • Captain gloves
  • Sabre sheathe

Mercenary loadout:

  • Captain's carapace

Changed some of the time requirements/prices for better consistency

Why / Balance

i am the captain

How to test

Check the contractor loadout (head, neck, jumpsuit, gloves, belt) and the mercenary loadout (outer clothing)

Media

incredible showcase even more updated

Requirements

Breaking changes

Changelog

🆑

  • add: Added the missing captain gear to loadouts.

Added some missing captain clothing to the loadouts

Moved a few things, changed most captain clothes to T2 and changed some prices
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine on the face of it, a few points of cleanup requested.

@@ -339,16 +339,16 @@
effects:
- !type:GroupLoadoutEffect
proto: ContractorT3
price: 2500
price: 1500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
price: 1500
price: 2500

Revert. If T3 items cost 2500, and this is a T3 item, it should cost 2500.

Copy link
Contributor Author

@Bonaout Bonaout Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the cloaks are a bit expensive, but I guess that's an issue for another PR

Also, aren't the T1, T2, T3 only meant as time requirements ? It seems a bit odd to me that they have to cost more just because they're "higher tier"

Comment on lines 346 to 353
- type: loadout
id: ContractorClothingNeckMantleCap
effects:
- !type:GroupLoadoutEffect
proto: ContractorT3
price: 2500
proto: ContractorT2
price: 1000
equipment:
neck: ClothingNeckMantleCap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is T2, move it to the T2 section.

Comment on lines +1613 to +1635
- type: loadout
id: ContractorClothingUniformJumpsuitCapFormal
effects:
- !type:GroupLoadoutEffect
proto: ContractorT3
hideEffects:
- !type:GroupLoadoutEffect
proto: PantsCapableNF
price: 1500
equipment:
jumpsuit: ClothingUniformJumpsuitCapFormal

- type: loadout
id: ContractorClothingUniformJumpskirtCapFormalDress
effects:
- !type:GroupLoadoutEffect
proto: ContractorT3
hideEffects:
- !type:GroupLoadoutEffect
proto: PantsCapableNF
price: 1500
equipment:
jumpsuit: ClothingUniformJumpskirtCapFormalDress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tier of item, denote as separate with a comment (see "# T3 "Military" below)

effects:
- !type:GroupLoadoutEffect
proto: ContractorT2
price: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
price: 1000
price: 1250

Consistency.

effects:
- !type:GroupLoadoutEffect
proto: ContractorT2
price: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
price: 1000
price: 1250

Consistency.

Comment on lines 138 to 145
- type: loadout
id: ContractorClothingHandsGlovesCaptain
effects:
- !type:GroupLoadoutEffect
proto: ContractorT2
price: 1000
equipment:
gloves: ClothingHandsGlovesCaptain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are in approximate order of value, reorder after the boxing gloves.

@@ -580,6 +586,7 @@
- ContractorClothingHandsGlovesColorOrange
- ContractorClothingHandsGlovesColorPurple
- ContractorClothingHandsGlovesColorRed
- ContractorClothingHandsGlovesCaptain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorder after the boxing gloves to be in increasing order of value.

@whatston3 whatston3 added S: Awaiting Changes This PR has changes that need to be made before merging and removed S: Untriaged labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# S: Awaiting Changes This PR has changes that need to be made before merging size/M YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants