Civillian and Medical ship Holopad update

[Cheackraze]

About the PR

Adds holopads to the 42 civilian/medical ships. Missing are, Caduceus(pending replacement any day now), Barge (already implemeneted), Pioneer(changes incoming) and Camper (no room-need design consideration)

Why / Balance

#2795 (comment)

How to test

Spawn the ships in your favorite method, in game or dev or mapping or testing, and see the glorious holopads

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• tweak: Added long-range holopads to most civillian ships

[dustylens]

There is a PR out for the Comet #2690 with a holopad already added. Does that seem acceptable? To prevent a conflict.

[dvir001]

Is any maptainer testing this or I'll need to? 👀

[arimah]

I'll get on with testing it tomorrow. :>

[arimah]

I've gone through all 42 ships, and the changes are pretty minimal. Looking promising so far!

Comments:

• Bulker: I don't love the placement of the holopad or the station records computer, but I will approve both. I'm not sure how else one could reasonably arrange things within the extremely limited available space.
• Comet: There is an open PR to revamp the Comet (Comet Defib Update #2690). I will merge this one first, as the other PR is enough of a rework that it'll probably take some time to review it properly, and I'd like to get holopads sorted sooner rather than later.
• Crescent, Harbormaster, Loader, Lyrae: The holopad is on top of a vent. Depending seemingly on the game's whims, though the holopad is visually on top, sometimes the vent "steals" mouse focus, forcing you to carefully click on the part of the holopad that's outside the vent. It's not great. I'm prepared to allow it for now, but I'd like to find a different, better long-term solution.
• McDelivery: This seems to have lost its station records computer. Are we no longer going to require those on tiny daughterships?

Ships not touched by this PR:

• Akupara
• Construct

Please verify that these are intended to be excluded. :)

[dvir001]

Record computer needed to track owner

[arimah]

Record computer needed to track owner

Are you sure about that? 🤔

[Tych0theSynth]

I've recently added a holopad to the Bodkin on my open PR to update it #2640

[Houtblokje]

• Crescent, Harbormaster, Loader, Lyrae: The holopad is on top of a vent. Depending seemingly on the game's whims, though the holopad is visually on top, sometimes the vent "steals" mouse focus, forcing you to carefully click on the part of the holopad that's outside the vent. It's not great. I'm prepared to allow it for now, but I'd like to find a different, better long-term solution.

That does seem bad. I understand maybe the harbormaster and Loader not having enough space to put the holopad, but is there really not enough space on the lyrae and the crescent (with crescent being one of the biggest ships currently in the game, and lyrae having that pretty large open lobby/hallway)?

[dvir001]

Record computer needed to track owner

Are you sure about that? 🤔

I mean you see the ship owner on it

[Houtblokje]

Record computer needed to track owner

Are you sure about that? 🤔

I mean you see the ship owner on it

I mean, only half of the time iirc but thats another issue.

[arimah]

Outstanding issues resolved in conversation on Discord. Over-vent holopads will be accepted for now. Akupara has a PR that reworks it (#2816), will let that introduce the holopad. Construct is skipped for now, will be included in a later batch. All ships approved. Let's get this show on the road. :)