Fill Sheriff's Locker & Move SR Access config to their locker. #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvir001
reviewed
Jan 31, 2025
|
Requested changes applied. |
dvir001
reviewed
Feb 8, 2025
whatston3
approved these changes
Feb 8, 2025
FrontierATC
added a commit
that referenced
this pull request
Feb 8, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Feb 24, 2025
…rontiers-14#2819) * Fill Sheriff's Locker & Move SR Access config to their locker. * No second medal case. * Move from locker to ptech. * Update sr.yml --------- Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com>
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Feb 24, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 1, 2025
…rontiers-14#2819) * Fill Sheriff's Locker & Move SR Access config to their locker. * No second medal case. * Move from locker to ptech. * Update sr.yml --------- Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com>
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 1, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 3, 2025
…rontiers-14#2819) * Fill Sheriff's Locker & Move SR Access config to their locker. * No second medal case. * Move from locker to ptech. * Update sr.yml --------- Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com>
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Filled the Sheriff's Locker on the NFSD Outpost (ID Card, Cuff Box, Demag, Access Config, etc.)
Moved the SR's Access Config from their bag to their locker.
EDIT: Access config is in the PTechs now, not locker.
Why / Balance
Firstly, currently if an SR is not ingame, no access configurator exists, which is a problem if needed by for example the DoC or the Sheriff.
Also, the sheriff used to get a few things in their locker, including the demag, but now they just don't. With this PR they get a demag, which is arguably more important for them then for the SR, alongside an access configurator for if they want to change NFSD Accesses (Add an armory lock to a bought armory crate, make certain areas on ships require higher access, etc.) Alongside some misc things such as a cuff box, comms console board, nfsd medal case, etc.
Also sidenote, yes I know that there is now an nfsd medal case on the Sheriff's desk and in their locker, but I feel like having extras doesn't hurt, for example if 2 civillians both deserve one of the civ medals.
How to test
Spawn as SR, Check the lockers for both Sheriff and SR.
Requirements
Changelog
🆑 BramvanZijp